Skip to content

to reduce misleading, add a note for [v-for with v-if] section #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2019

Conversation

zdsfwy
Copy link
Contributor

@zdsfwy zdsfwy commented Feb 23, 2019

When reading the Vue document, I found section v-for with v-if doesn't include any information about the fact that v-for and v-if are not recommended to be used together. I see in some other section it's kindly mentioned. I think it's necessary to also mention it here to not mislead readers.

@phanan
Copy link
Member

phanan commented Feb 24, 2019

Thanks! Do you think we should put the tip at the beginning of the section, in the same fashion as "v-if with v-for"?

@zdsfwy
Copy link
Contributor Author

zdsfwy commented Feb 24, 2019

Hi @phanan , thanks for the good point! I have updated the PR correspondingly.

@sdras
Copy link
Member

sdras commented Feb 25, 2019

This looks good! Thank you :)

@sdras sdras merged commit fc6b292 into vuejs:master Feb 25, 2019
phanan pushed a commit to phanan-forks/vuejs.org that referenced this pull request Mar 14, 2019
…#2029)

* to reduce misleading, add a note for [v-for with v-if] section

* move note to the top of the target section
phanan pushed a commit to phanan-forks/vuejs.org that referenced this pull request Mar 20, 2019
…#2029)

* to reduce misleading, add a note for [v-for with v-if] section

* move note to the top of the target section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants